Skip to content

Update Saas resource in SaasRuntime with applicationTemplate property#17762

Draft
neil-dey wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
neil-dey:main
Draft

Update Saas resource in SaasRuntime with applicationTemplate property#17762
neil-dey wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
neil-dey:main

Conversation

@neil-dey
Copy link
Copy Markdown

@neil-dey neil-dey commented May 28, 2026 •
edited
Loading 

saasservicemgmt: added `applicationTemplate`, `blueprintRepo`, `conditions`, `error`, and `state` fields to `Saas` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 28, 2026
@neil-dey neil-dey marked this pull request as ready for review May 29, 2026 17:32
@github-actions github-actions Bot requested a review from slevenick May 29, 2026 17:32
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

slevenick
slevenick reviewed May 29, 2026
View reviewed changes
Comment thread mmv1/products/saasservicemgmt/Saas.yaml Outdated
type: NestedObject
description: |-
CompositeRef represents a reference to a composite resource.
Next ID: 4
Copy link
Copy Markdown
Contributor

@slevenick slevenick May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next ID?

Comment thread mmv1/products/saasservicemgmt/Saas.yaml
Comment thread mmv1/products/saasservicemgmt/Saas.yaml
Comment thread mmv1/templates/terraform/custom_delete/saas_runtime_saas_delete.go.tmpl

headers := make(http.Header)

// 1. Wait for the resource to transition out of STATE_RUNNING before deleting
Copy link
Copy Markdown
Contributor

@slevenick slevenick May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long does this reasonably take? Should we set limits here on how long to wait on this?

Copy link
Copy Markdown
Author

@neil-dey neil-dey Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation uses the default timeout of 20 minutes, which we believe is reasonable. Furthermore, leaving the default lets the user configure it if needed; if we set a hardcoded timeout, users would lose the ability to configure a custom value. https://developer.hashicorp.com/terraform/plugin/sdkv2/resources/retries-and-customizable-timeouts

@github-actions github-actions Bot requested a review from slevenick June 3, 2026 16:57
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 3, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Jun 3, 2026 •
edited
Loading

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2e50584:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 100 insertions(+)
google-beta provider View Diff 6 files changed, 525 insertions(+), 233 deletions(-)
terraform-google-conversion View Diff 1 file changed, 54 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
13 0 0 13
Affected Service Packages
  • saasruntime

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccSaasRuntimeRelease_saasRuntimeReleaseBasicExample
  • TestAccSaasRuntimeRelease_update
  • TestAccSaasRuntimeRolloutKind_saasRuntimeRolloutKindBasicExample
  • TestAccSaasRuntimeRolloutKind_update
  • TestAccSaasRuntimeSaas_saasRuntimeSaasBasicExample
  • TestAccSaasRuntimeSaas_update
  • TestAccSaasRuntimeTenant_saasRuntimeTenantBasicExample
  • TestAccSaasRuntimeTenant_update
  • TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample
  • TestAccSaasRuntimeUnitKind_update
  • TestAccSaasRuntimeUnitOperation_saasRuntimeUnitOperationBasicExample
  • TestAccSaasRuntimeUnit_saasRuntimeUnitBasicExample
  • TestAccSaasRuntimeUnit_update

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ✅ TestAccSaasRuntimeRolloutKind_saasRuntimeRolloutKindBasicExample
✅ Log ✅ TestAccSaasRuntimeRolloutKind_update
✅ Log ✅ TestAccSaasRuntimeSaas_update
✅ Log ✅ TestAccSaasRuntimeTenant_saasRuntimeTenantBasicExample
✅ Log ✅ TestAccSaasRuntimeTenant_update
✅ Log ✅ TestAccSaasRuntimeUnitKind_saasRuntimeUnitKindBasicExample
✅ Log ✅ TestAccSaasRuntimeUnitKind_update
✅ Log ✅ TestAccSaasRuntimeUnit_saasRuntimeUnitBasicExample
✅ Log ✅ TestAccSaasRuntimeUnit_update
❌ Error · Log - TestAccSaasRuntimeRelease_saasRuntimeReleaseBasicExample
❌ Error · Log - TestAccSaasRuntimeRelease_update
❌ Error · Log - TestAccSaasRuntimeSaas_saasRuntimeSaasBasicExample
❌ Error · Log - TestAccSaasRuntimeUnitOperation_saasRuntimeUnitOperationBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@neil-dey, @slevenick VCR tests complete for 2e50584!

@neil-dey neil-dey marked this pull request as draft June 3, 2026 17:38
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Jun 3, 2026 •
edited
Loading

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a09944a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 100 insertions(+), 5 deletions(-)
google-beta provider View Diff 6 files changed, 527 insertions(+), 239 deletions(-)
terraform-google-conversion View Diff 1 file changed, 54 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
13 9 0 4
Affected Service Packages
  • saasruntime

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccSaasRuntimeRelease_saasRuntimeReleaseBasicExample
  • TestAccSaasRuntimeRelease_update
  • TestAccSaasRuntimeSaas_saasRuntimeSaasBasicExample
  • TestAccSaasRuntimeUnitOperation_saasRuntimeUnitOperationBasicExample

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ✅ TestAccSaasRuntimeSaas_saasRuntimeSaasBasicExample
❌ Error · Log - TestAccSaasRuntimeRelease_saasRuntimeReleaseBasicExample
❌ Error · Log - TestAccSaasRuntimeRelease_update
❌ Error · Log - TestAccSaasRuntimeUnitOperation_saasRuntimeUnitOperationBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@neil-dey, @slevenick VCR tests complete for a09944a!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slevenick slevenick Awaiting requested review from slevenick

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

service/saasservicemgmt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neil-dey @modular-magician @slevenick